Skip to content

Fix double-checked locking #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chickenlj merged 1 commit into from
Jan 24, 2019
Merged

Fix double-checked locking #3323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...report-api/src/main/java/org/apache/dubbo/metadata/integration/MetadataReportService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class MetadataReportService {

protected final Logger logger = LoggerFactory.getLogger(getClass());

private static MetadataReportService metadataReportService;
private static volatile MetadataReportService metadataReportService;
private static Object lock = new Object();

private MetadataReportFactory metadataReportFactory = ExtensionLoader.getExtensionLoader(MetadataReportFactory.class).getAdaptiveExtension();
Expand Down
2 changes: 1 addition & 1 deletion ...ta-report-api/src/main/java/org/apache/dubbo/metadata/support/AbstractMetadataReport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ class MetadataReportRetry {
protected final Logger logger = LoggerFactory.getLogger(getClass());

final ScheduledExecutorService retryExecutor = Executors.newScheduledThreadPool(0, new NamedThreadFactory("DubboRegistryFailedRetryTimer", true));
ScheduledFuture retryScheduledFuture;
volatile ScheduledFuture retryScheduledFuture;
AtomicInteger retryCounter = new AtomicInteger(0);
// retry task schedule period
long retryPeriod;
Expand Down
⚡