Skip to content

Modify MetadataReportRetry ThreadName #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carryxyh merged 3 commits into from
Feb 22, 2019
Merged

Modify MetadataReportRetry ThreadName #3550

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0a8422
fix #2842. remove duplicate SPI definitions for 2.7.x
cvictory Jan 25, 2019
98b2f4b
Merge branch 'master' of github.com:apache/incubator-dubbo
cvictory Feb 21, 2019
19824c3
fix: rename the thread name from DubboRegistryFailedRetryTimer to Dub…
cvictory Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ta-report-api/src/main/java/org/apache/dubbo/metadata/support/AbstractMetadataReport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public abstract class AbstractMetadataReport implements MetadataReport {
// Log output
protected final Logger logger = LoggerFactory.getLogger(getClass());

// Local disk cache, where the special key value.registries records the list of registry centers, and the others are the list of notified service providers
// Local disk cache, where the special key value.registries records the list of metadata centers, and the others are the list of notified service providers
final Properties properties = new Properties();
private final ExecutorService reportCacheExecutor = Executors.newFixedThreadPool(1, new NamedThreadFactory("DubboSaveMetadataReport", true));
final Map<MetadataIdentifier, Object> allMetadataReports = new ConcurrentHashMap<>(4);
Expand Down Expand Up @@ -336,7 +336,7 @@ long calculateStartTime() {
class MetadataReportRetry {
protected final Logger logger = LoggerFactory.getLogger(getClass());

final ScheduledExecutorService retryExecutor = Executors.newScheduledThreadPool(0, new NamedThreadFactory("DubboRegistryFailedRetryTimer", true));
final ScheduledExecutorService retryExecutor = Executors.newScheduledThreadPool(0, new NamedThreadFactory("DubboMetadataReportRetryTimer", true));
volatile ScheduledFuture retryScheduledFuture;
AtomicInteger retryCounter = new AtomicInteger(0);
// retry task schedule period
Expand All @@ -358,7 +358,7 @@ void startRetryTask() {
retryScheduledFuture = retryExecutor.scheduleWithFixedDelay(new Runnable() {
@Override
public void run() {
// Check and connect to the registry
// Check and connect to the metadata
try {
int times = retryCounter.incrementAndGet();
logger.info("start to retry task for metadata report. retry times:" + times);
Expand Down
⚡