Skip to content

[Dubbo-3669]do local export before register any listener. #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralf0131 merged 5 commits into from
May 16, 2019
Merged

[Dubbo-3669]do local export before register any listener. #3685

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
387013d
do local export before register any listener.
chickenlj Mar 18, 2019
de3d6f6
revert delete of ProviderConfigurationListener init.
chickenlj May 14, 2019
f484415
only parse rules on init, does not override.
chickenlj May 16, 2019
d7c6589
revert change in RegistryProtocol
chickenlj May 16, 2019
2c17623
extract code to one single method.
chickenlj May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...bo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ public <T> Exporter<T> export(final Invoker<T> originInvoker) throws RpcExceptio
// url to export locally
URL providerUrl = getProviderUrl(originInvoker);

//export invoker
final ExporterChangeableWrapper<T> exporter = doLocalExport(originInvoker, providerUrl);
Comment thread
chickenlj marked this conversation as resolved.
Outdated

// Subscribe the override data
// FIXME When the provider subscribes, it will affect the scene : a certain JVM exposes the service and call
// the same service. Because the subscribed is cached key with the name of the service, it causes the
Expand All @@ -180,8 +183,6 @@ public <T> Exporter<T> export(final Invoker<T> originInvoker) throws RpcExceptio
overrideListeners.put(overrideSubscribeUrl, overrideSubscribeListener);

providerUrl = overrideUrlWithConfig(providerUrl, overrideSubscribeListener);
//export invoker
final ExporterChangeableWrapper<T> exporter = doLocalExport(originInvoker, providerUrl);

// url to registry
final Registry registry = getRegistry(originInvoker);
Expand Down
⚡