Metrics Service#3702
Closed
panxiaojun233 wants to merge 0 commit intoapache:masterfrom
panxiaojun233:master
Closed
Metrics Service#3702panxiaojun233 wants to merge 0 commit intoapache:masterfrom panxiaojun233:master
panxiaojun233 wants to merge 0 commit intoapache:masterfrom
panxiaojun233:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3702 +/- ##
============================================
+ Coverage 63.46% 63.64% +0.18%
Complexity 71 71
============================================
Files 703 704 +1
Lines 31002 31046 +44
Branches 5023 5025 +2
============================================
+ Hits 19675 19759 +84
+ Misses 9060 9016 -44
- Partials 2267 2271 +4
Continue to review full report at Codecov.
|
kezhenxu94
requested changes
Mar 27, 2019
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
There are changes that are irrelavant (CRLF and LF) in some files:
ReferenceConfig.java, ServiceConfig.java, and DubboNamespaceHandler.java (and maybe others). @panxiaojun233 could you please revert the irrelavant changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
By exposing Dubbo's built-in service, Dubbo-admin can collect data from Metrics statistics.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.