Skip to content

[DUBBO-3746] Bugfix: infinite loop in AbstractRegistry when IOException. fix #3746 #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralf0131 merged 3 commits into from
Apr 17, 2019
Merged

[DUBBO-3746] Bugfix: infinite loop in AbstractRegistry when IOException. fix #3746 #3748

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afe19c0
bugfix: dead loop in AbstractRegistry when IOException. fix #3746
kezhenxu94 Mar 27, 2019
2a22ca8
limit retry times to save properties to local file
kezhenxu94 Mar 28, 2019
b4310a9
limit retry times to save properties to local file
kezhenxu94 Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/AbstractRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ public void doSaveProperties(long version) {
}
}
} catch (Throwable e) {
if (e instanceof IOException) { // may not be recoverable when IOException throws, give up retrying
Comment thread
kezhenxu94 marked this conversation as resolved.
Outdated
logger.warn("Failed to save registry cache file, cause: " + e.getMessage(), e);
return;
}
if (version < lastCacheChanged.get()) {
return;
} else {
Expand Down
⚡