fix DubboBeanDefinitionParser.parse() Error #3843#3844
Closed
CrazyHZM wants to merge 2 commits intoapache:masterfrom
Closed
fix DubboBeanDefinitionParser.parse() Error #3843#3844CrazyHZM wants to merge 2 commits intoapache:masterfrom
CrazyHZM wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3844 +/- ##
===========================================
+ Coverage 63.58% 63.6% +0.02%
Complexity 71 71
===========================================
Files 708 708
Lines 31196 31195 -1
Branches 5048 5048
===========================================
+ Hits 19835 19843 +8
+ Misses 9080 9073 -7
+ Partials 2281 2279 -2
Continue to review full report at Codecov.
|
chenlushun
reviewed
Apr 10, 2019
Member
Author
是的,这里直接把打印的日志去掉就可以了,这个getter只是为了不再走下面的解析逻辑。所以不需要打印error日志 |
chenlushun
approved these changes
Apr 10, 2019
Member
Author
|
resolved #3862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix DubboBeanDefinitionParser.parse() Error #3843
follow polish code #3823
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.