Skip to content

use maven CI friendly versions: revision, cherry-pick to 3.x.#3852

Merged
ralf0131 merged 3 commits intoapache:3.x-devfrom
chickenlj:3.x-dev
Apr 12, 2019
Merged

use maven CI friendly versions: revision, cherry-pick to 3.x.#3852
ralf0131 merged 3 commits intoapache:3.x-devfrom
chickenlj:3.x-dev

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

What is the purpose of the change

The same effort as #3851, only this one is for 3.x.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Comment thread pom.xml Outdated
Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit b26604f into apache:3.x-dev Apr 12, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3852 into 3.x-dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3852      +/-   ##
=============================================
+ Coverage      63.59%   63.67%   +0.08%     
  Complexity        71       71              
=============================================
  Files            705      706       +1     
  Lines          31068    31072       +4     
  Branches        5027     5029       +2     
=============================================
+ Hits           19757    19786      +29     
+ Misses          9033     9009      -24     
+ Partials        2278     2277       -1
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/dubbo/remoting/exchange/Response.java 69.09% <0%> (-25.91%) 0% <0%> (ø)
.../org/apache/dubbo/rpc/filter/CompatibleFilter.java 60% <0%> (-23.34%) 0% <0%> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 76.19% <0%> (-10.48%) 0% <0%> (ø)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 63.73% <0%> (-6.6%) 0% <0%> (ø)
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 83.33% <0%> (-4.91%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 60% <0%> (-4.52%) 0% <0%> (ø)
...rg/apache/dubbo/monitor/support/MonitorFilter.java 71.42% <0%> (-4.44%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 64.17% <0%> (-4.25%) 0% <0%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91554bc...10e7792. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants