bugfix/remove-parse-error-log#3862
Merged
chickenlj merged 1 commit intoapache:masterfrom Apr 12, 2019
Merged
Conversation
chickenlj
approved these changes
Apr 12, 2019
Contributor
chickenlj
left a comment
chickenlj
left a comment
There was a problem hiding this comment.
LGTM.
The error log added before was unnecessary and misleading.
chenlushun
approved these changes
Apr 12, 2019
Member
|
I also submitted this part of the fix before, then I closed my submission. #3844 |
This was referenced Apr 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #3862 +/- ##
============================================
- Coverage 63.59% 63.58% -0.02%
Complexity 71 71
============================================
Files 708 708
Lines 31196 31195 -1
Branches 5048 5048
============================================
- Hits 19839 19834 -5
- Misses 9074 9080 +6
+ Partials 2283 2281 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
there is no need for any log in DubboBeanDefinitionParser since some class implements the interface: EnvironmentAware, ApplicationAware, etc. They only have setter methods, otherwise will cause the error log during application startup.
Brief changelog
remove the error log