[Dubbo-3886] Integrate with SOFARegistry.#3886
Merged
lovepoem merged 9 commits intoapache:masterfrom May 2, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3886 +/- ##
===========================================
+ Coverage 63.85% 63.95% +0.1%
Complexity 98 98
===========================================
Files 715 718 +3
Lines 31457 31613 +156
Branches 5049 5090 +41
===========================================
+ Hits 20086 20218 +132
- Misses 9061 9078 +17
- Partials 2310 2317 +7
Continue to review full report at Codecov.
|
Member
Author
|
@ralf0131 Please review this PR. |
Contributor
|
I will try to do it today or tomorrow.. |
ralf0131
requested changes
Apr 26, 2019
Contributor
ralf0131
left a comment
There was a problem hiding this comment.
Please following the guide to add a new module: apache/dubbo-website#350
There are some things to do:
- Add your dependency to dubbo-bom/pom.xml
- Add your dependency to dubbo-distribution/pom.xml
- Update dubbo-dependencies if necessary
- Could you list the license of your dependencies to make sure they are compatible with Apache
lovepoem
reviewed
Apr 26, 2019
lovepoem
reviewed
Apr 26, 2019
lovepoem
reviewed
Apr 26, 2019
lovepoem
reviewed
Apr 26, 2019
b5a6d77 to
b5f8218
Compare
0b1ac21 to
3e6157c
Compare
Member
Author
Contributor
|
@lovepoem What is you opinion on this? |
Contributor
|
I checked the license of dubbo-registry-sofa dependencies. All looks good. |
lovepoem
approved these changes
May 2, 2019
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#3874
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.