Skip to content

Result implements future.#3916

Merged
chickenlj merged 7 commits intoapache:3.x-devfrom
chickenlj:result-implements-future
Apr 24, 2019
Merged

Result implements future.#3916
chickenlj merged 7 commits intoapache:3.x-devfrom
chickenlj:result-implements-future

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Make Result a type of CompletionStage.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj
Copy link
Copy Markdown
Contributor Author

Notice I am merging this PR to solve some compatible problems. Please help to review later for anyone who may be interested.

@chickenlj chickenlj merged commit ed8a36b into apache:3.x-dev Apr 24, 2019
chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant