Merged
Conversation
Contributor
lexburner
commented
Apr 29, 2019
- filter network interface in NetUtils
- remove the useless attribute in ApplicationConfig
…te in ApplicationConfig
Contributor
|
Hi, I observed that the UT are failing, I've trigger a new build. If there is still error, please keep an eye on it and fix it. |
Contributor
|
Hi, please resolve the UT failures. |
Codecov Report
@@ Coverage Diff @@
## master #3953 +/- ##
===========================================
- Coverage 63.85% 63.6% -0.26%
- Complexity 98 100 +2
===========================================
Files 713 720 +7
Lines 31481 31838 +357
Branches 5076 5113 +37
===========================================
+ Hits 20102 20250 +148
- Misses 9071 9270 +199
- Partials 2308 2318 +10
Continue to review full report at Codecov.
|
Contributor
Author
|
fixed now |
beiwei30
approved these changes
May 5, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.