Conversation
| <artifactId>junit</artifactId> | ||
| <version>${junit_version}</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Junit 4 is not necessary.
Junit 5 is included in the parent pom and it can be used directly inside the new module without any extra declaration.
| <groupId>javax.annotation</groupId> | ||
| <artifactId>javax.annotation-api</artifactId> | ||
| <version>${javax_annotation_api_version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Why do we need this declaration? I don't find the place where it was referenced.
There was a problem hiding this comment.
yes. i'll remove..i'm just merge this from rpc-native-thrift-for-apache-dubbo to here. it's my fault.btw i find the thirft version of rpc-native-thrift and rpc-thrift is not same. should i make it same or declare 0.11 just in rpc-native-thrift module ??
Codecov Report
@@ Coverage Diff @@
## master #3965 +/- ##
============================================
- Coverage 63.97% 63.76% -0.21%
+ Complexity 98 71 -27
============================================
Files 715 744 +29
Lines 31493 32206 +713
Branches 5074 5124 +50
============================================
+ Hits 20147 20536 +389
- Misses 9048 9322 +274
- Partials 2298 2348 +50
Continue to review full report at Codecov.
|
|
sorry about it. just noticed you had a pull request for the same issue after I merged #3977 from @Leishunyu. |
|
pls. improve #3977 if you see any inappropriate. |
4 participants
What is the purpose of the change
Merge rpc-native-thrift-for-apache-dubbo into incubator-dubbo #3960
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.