Conversation
Codecov Report
@@ Coverage Diff @@
## master #3981 +/- ##
============================================
+ Coverage 63.68% 63.74% +0.06%
Complexity 71 71
============================================
Files 743 744 +1
Lines 32125 32126 +1
Branches 5120 5120
============================================
+ Hits 20458 20480 +22
+ Misses 9322 9296 -26
- Partials 2345 2350 +5
Continue to review full report at Codecov.
|
|
it is indeed a good idea, but it is incomplete solution. Instead, we should examine Constants throughly and classify all constants in it carefully. What I suggest is we should divide this work into four steps:
I will file one new issue to track this work. |
|
It's tracked now by #3137. I will do the step 1 first, after that, we could start to divide the works for step2 and step3 |
|
This is a good plan. After your first step is completed, I will participate in the follow-up work. |
|
sure, thanks. |
What is the purpose of the change
Constants is too large, divided into module Constants to manage constants
follow #3967
add SerializationConstants
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.