use equal explicit class to replace anonymous class#4027
Merged
ralf0131 merged 1 commit intoapache:masterfrom May 12, 2019
Merged
use equal explicit class to replace anonymous class#4027ralf0131 merged 1 commit intoapache:masterfrom
ralf0131 merged 1 commit intoapache:masterfrom
Conversation
b149265 to
0f25880
Compare
Codecov Report
@@ Coverage Diff @@
## master #4027 +/- ##
===========================================
+ Coverage 63.42% 64.73% +1.3%
- Complexity 564 600 +36
===========================================
Files 755 755
Lines 32425 34661 +2236
Branches 5145 5968 +823
===========================================
+ Hits 20567 22438 +1871
- Misses 9496 9830 +334
- Partials 2362 2393 +31
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The anonymous class used in AvailableCluster's constructor has a equal explicit class, we can use the explicit one to replace the anonymous one.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.