[Dubbo-4183] Fix unstable tests in ConditionRouterTest #4226
[Dubbo-4183] Fix unstable tests in ConditionRouterTest #4226lovepoem merged 3 commits intoapache:masterfrom htynkn:chore/stable-ut
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4226 +/- ##
=========================================
Coverage ? 62.89%
Complexity ? 505
=========================================
Files ? 769
Lines ? 33058
Branches ? 5217
=========================================
Hits ? 20791
Misses ? 9869
Partials ? 2398Continue to review full report at Codecov.
|
|
testStoreProvider still need someone to have a look. that issue will not close by this PR |
slievrly
left a comment
There was a problem hiding this comment.
check CRLF or LF line separators in ConditionRouterTest.java.
Fixed |
slievrly
left a comment
There was a problem hiding this comment.
LGTM
If the ip of the ci machine is 10.20.3.*, it will affect the conditional judgment of host = xxxx => host = 10.20.3.* & host != 10.20.3.3. There are 2 options here: 1. Set the service provider to fixed ip 2. Remove the * judgment of this case
What is the purpose of the change
Make unit test stable
Brief changelog
Remove network dependency in unit test (ConditionRouterTest) close #4183
Ignore unstable test (EtcdMetadataReportTest) refer #4185
Verifying this change
CI Pass
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.