[Dubbo-3370]support 'merge' attribute in @Reference and @Method #4619
Closed
shalk wants to merge 1 commit intoapache:masterfrom
Closed
[Dubbo-3370]support 'merge' attribute in @Reference and @Method #4619shalk wants to merge 1 commit intoapache:masterfrom
shalk wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4619 +/- ##
============================================
- Coverage 64.17% 64.14% -0.03%
Complexity 452 452
============================================
Files 768 768
Lines 32873 32869 -4
Branches 5181 5179 -2
============================================
- Hits 21096 21085 -11
- Misses 9361 9370 +9
+ Partials 2416 2414 -2
Continue to review full report at Codecov.
|
Author
|
@chickenlj could you review my code? |
Author
|
306954a to
ef4268b
Compare
ef4268b to
5d0e103
Compare
Member
|
This pull request may duplicated with #6092. Please feel free to reopen if you have any question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
to support merge attribute in
@Referenceand@Methodexample:
Brief changelog
@Referenceand@MethodReferenceConfigTest.javaandMethodConfigJavato test getter, setter and construct from annotationAnnotationPropertyValuesAdapterTest.javacheck databind for mergerReferenceBeanBuilderTest.javato verify referencebean will contain merger infoVerifying this change
unit test :
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.