fix NacosRegistry weight missing issue#5144
Merged
mercyblitz merged 1 commit intoapache:2.6.xfrom Nov 19, 2019
brucelwl:2.6.x
Merged
fix NacosRegistry weight missing issue#5144mercyblitz merged 1 commit intoapache:2.6.xfrom brucelwl:2.6.x
mercyblitz merged 1 commit intoapache:2.6.xfrom
brucelwl:2.6.x
Conversation
Contributor
Author
|
@htynkn first-time-contributor 怎么定义? |
Member
This user is a first-time contributor to the dubbo repository. There is a tag in PR page 用户第一次给dubbo库贡献。右上角Github会给一个标注 |
Contributor
Author
|
@htynkn 我应该不是第一次贡献代码了 |
Member
|
这个具体Github为什么识别成首次贡献者我不太清楚,可能是账号原因,可能是commit中的邮箱配置,可能是库的问题。 |
Contributor
Author
|
@htynkn 请几天还能在这里找到我,现在找不到了 https://github.com/apache/dubbo/graphs/contributors |
Member
|
You are right. refer to: #4955 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

nacos客户端默认设置weight=1.0

而dubbo权重默认设置的是100,
dubbo通过
NacosRegistry注册服务时没有设置,导致权重获取bug