Skip to content

support epoll on linux, alternative impl of PR#4493#5680

Merged
chickenlj merged 2 commits intoapache:masterfrom
beiwei30:pr4493
Jan 31, 2020
Merged

support epoll on linux, alternative impl of PR#4493#5680
chickenlj merged 2 commits intoapache:masterfrom
beiwei30:pr4493

Conversation

@beiwei30
Copy link
Copy Markdown
Member

What is the purpose of the change

alternative impl for PR #4493

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 added this to the 2.7.6 milestone Jan 17, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5680 into master will increase coverage by 0.06%.
The diff coverage is 65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5680      +/-   ##
============================================
+ Coverage     61.15%   61.22%   +0.06%     
- Complexity      421      422       +1     
============================================
  Files           923      924       +1     
  Lines         37568    37589      +21     
  Branches       5441     5446       +5     
============================================
+ Hits          22976    23015      +39     
+ Misses        12106    12077      -29     
- Partials       2486     2497      +11
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/remoting/transport/netty4/NettyServer.java 73.52% <100%> (+0.39%) 0 <0> (ø) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <100%> (ø) 0 <0> (ø) ⬇️
...moting/transport/netty4/NettyEventLoopFactory.java 36.36% <36.36%> (ø) 0 <0> (?)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
...ache/dubbo/validation/filter/ValidationFilter.java 82.6% <0%> (-3.11%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 82.88% <0%> (-2.71%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (+0.34%) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0%> (+1.9%) 16% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a69ea...d7ad03e. Read the comment docs.

@chickenlj
Copy link
Copy Markdown
Contributor

LGTM.

@chickenlj chickenlj merged commit c6413a9 into apache:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants