HIVE-29555: [HPLSQL]Errorcode handling is not proper in HPLSQL.#6422
Open
mdayakar wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29555: [HPLSQL]Errorcode handling is not proper in HPLSQL.#6422mdayakar wants to merge 1 commit intoapache:masterfrom
mdayakar wants to merge 1 commit intoapache:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIVE-29555: [HPLSQL]Errorcode handling is not proper in HPLSQL.
What changes were proposed in this pull request?
When SQL statements are executed using EXECUTE/EXECUTE IMMEDIATE, in positive scenario the ERRORCODE is not set as SUCCESS. The default value for ERRORCODE is SUCCESS so even without setting the errorcode to success in positive scenario is fine but if the ERRORCODE is set as ERROR as a part of previous statement execution then another statement is executed successfully but still ERRORCODE is already set as ERROR which is not correct. Now in positive flow also we are setting SUCCESS for the ERRORCODE.
Why are the changes needed?
To fix the error reported in HIVE-29555.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added testcase to test the scenario.
mvn test -Dtest=TestHplSqlViaBeeLine#testERRORCODEForExecuteStatements -pl itests/hive-unit -Pitests