merge thrift#3977
Merged
beiwei30 merged 8 commits intoapache:masterfrom May 6, 2019
Leishunyu:merge-thrift
Merged
Conversation
beiwei30
reviewed
May 5, 2019
lovepoem
previously requested changes
May 5, 2019
Member
lovepoem
left a comment
There was a problem hiding this comment.
I think it's better to keep the two modules[1] together for a while now.
[1] dubbo-rpc-thrift and dubbo-rpc-native-thrift
So we should upgrade the thrift version to 11 in dubbo-rpc-thrift
Codecov Report
@@ Coverage Diff @@
## master #3977 +/- ##
============================================
+ Coverage 63.68% 63.74% +0.06%
Complexity 71 71
============================================
Files 743 744 +1
Lines 32125 32205 +80
Branches 5120 5124 +4
============================================
+ Hits 20458 20529 +71
- Misses 9322 9326 +4
- Partials 2345 2350 +5
Continue to review full report at Codecov.
|
Contributor
Author
i think so, i change it |
beiwei30
reviewed
May 6, 2019
beiwei30
reviewed
May 6, 2019
beiwei30
reviewed
May 6, 2019
beiwei30
approved these changes
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#3960
Brief changelog
Cover the original thrift
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.