BITPOS doesn't support BIT option

[lt1946]

Search before asking

• I had searched in the issues and found no similar issues.

Version

latest

Minimal reproduce step

from redis command : https://redis.io/commands/bitpos/
redis> SET mykey "\x00\xff\xf0"
"OK"

What did you expect to see?

redis> BITPOS mykey 1 7 15 BIT
(integer) 9

What did you see instead?

redis> BITPOS mykey 1 7 15 BIT
(integer) 57

Anything Else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[torwig]

Hi @lt1946, thank you for your report.
On my machine, with Redis I have the following:

[yaroslav@localhost ~]$ redis-cli
127.0.0.1:6379> SET mykey1 "\x00\xff\xf0"
OK
127.0.0.1:6379> BITPOS mykey1 1 7 15 BIT
(integer) 8

However, you said that you expect to see 9.

Kvrocks behaves in the following way:

127.0.0.1:6666> SET mykey "\x00\xff\xf0"
OK
127.0.0.1:6666> BITPOS mykey 1 7 15 BIT
(integer) -1

And it needs an investigation.

[torwig]

@lt1946 I got the reason why the result is -1. Currently, the BITPOS command doesn't support BIT flag, so it considers start and end values as bytes.

127.0.0.1:6379> BITPOS mykey1 1 1 2
(integer) 8
127.0.0.1:6379> BITPOS mykey1 1 2 3
(integer) 16

[tisonkun]

I'd suggest adding a comment/description in the document https://kvrocks.apache.org/docs/supported-commands#bit-commands and closing this issue.