Skip to content

Upgrade to Gradle 9.1.0#15236

Merged
dweiss merged 15 commits intoapache:mainfrom
dweiss:gradle-9.1.0
Sep 29, 2025
Merged

Upgrade to Gradle 9.1.0#15236
dweiss merged 15 commits intoapache:mainfrom
dweiss:gradle-9.1.0

Conversation

@dweiss
Copy link
Copy Markdown
Contributor

@dweiss dweiss commented Sep 26, 2025

This is a work in progress patch.

I've tried to assess how much is not working after an upgrade to gradle 9.1.0 and it seems most of the infrastructure works fine. Regeneration doesn't work (I know why). I'll try to push it forward but it seems like it's not going to be as complicated as I thought.

Issues to resolve:

  • (fixed by 15240) this passes for me locally but only because the build directory is created first, racy;
Configuring project ':lucene:build-tools' without an existing directory is not allowed. The configured projectDirectory '/home/runner/work/lucene/lucene/lucene/build-tools' does not exist, can't be written to or is not a directory.
  • (fixed by 15244) regeneration tasks don't work (project.exec removed)
  • ensure everything works with jdk24 after all the changes have been applied
  • temporarily disable forbidden-apis checker until it supports jdk 25 (tracking issue 15246)
  • wait for ecj support of Java 25 or use a custom copy of the latest drop. (as it was in the now removed 015b3bb#diff-d8369391f4d26d4041b621158bf7f0b934a40c4dd98850e3d734fc985d38e257)
  • update gh workflows to include jdk 25

Related patch #15238

@dweiss dweiss added this to the 11.0.0 milestone Sep 26, 2025
@dweiss dweiss self-assigned this Sep 26, 2025
@dweiss dweiss linked an issue Sep 26, 2025 that may be closed by this pull request
@dweiss
Copy link
Copy Markdown
Contributor Author

dweiss commented Sep 27, 2025

I've made some reasonable progress. I'll try to make ecj work tomorrow and see what's left.

@dweiss dweiss marked this pull request as ready for review September 28, 2025 18:57
@dweiss
Copy link
Copy Markdown
Contributor Author

dweiss commented Sep 28, 2025

I think everything works... I checked everything locally and the gh workflow that verifies gradle upgrade sanity is also passing. We can wait for Uwe to release forbidden-apis or merge this in and remove the temporary code that turns forbidden apis off (#15246).

@rmuir
Copy link
Copy Markdown
Member

rmuir commented Sep 28, 2025

Wow, I think merge now to reduce any hassles and let's smooth anything out as a followup?

@dweiss
Copy link
Copy Markdown
Contributor Author

dweiss commented Sep 28, 2025

Merging this will also need to be coordinated with switching all jenkins workflows to jdk 25... which I'm not sure is installed on worker machines (asf infra, uwe's box)? I'll create a sub-issue to investigate this.

Copy link
Copy Markdown
Contributor

@kaivalnp kaivalnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread build.gradle
// https://github.com/policeman-tools/forbidden-apis/pull/272
allprojects {
tasks.withType(CheckForbiddenApis.class).configureEach {
enabled = false
Copy link
Copy Markdown
Contributor

@uschindler uschindler Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reenable it like this: targetVersion = "24"

Then it runs, but with older signatures!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this as an interim commit under #15246

Comment thread README.md
### Basic steps:

1. Install [OpenJDK 24](https://jdk.java.net/archive/).
1. Install [OpenJDK 25](https://jdk.java.net/archive/).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link here only shows java 24 as latest. Maybe only point to home page.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct link is: https://jdk.java.net/25/ (but it may not be persistent)

@dweiss dweiss merged commit 74681c8 into apache:main Sep 29, 2025
12 checks passed
@dweiss dweiss deleted the gradle-9.1.0 branch September 29, 2025 10:49
dweiss added a commit to dweiss/lucene that referenced this pull request Sep 30, 2025
dweiss added a commit that referenced this pull request Sep 30, 2025
* Fix smoke tester test workflow to run with Java 25 #15236.
* Adding unsupported indexes for 9.12.3 for the smoke tester.
dweiss added a commit that referenced this pull request Sep 30, 2025
* Fix smoke tester test workflow to run with Java 25 #15236.
* Adding unsupported indexes for 9.12.3 for the smoke tester.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java 25 support

4 participants