Skip to content

Replace deprecated setGoals method #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elharo wants to merge 1 commit into from
Closed

Replace deprecated setGoals method #1441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ease-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public void executeGoals(
targetGoals.add(additionalArguments);
}

req.setGoals(targetGoals);
req.addArgs(targetGoals);
Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a good idea. Each argument passed to setGoals are internal parsed, escaped and so on ...
but addArgs pass arguments as is to command line process

look at line 113 additionalArguments is add as one item to list

Copy link
Copy Markdown
Contributor Author

@elharo elharo Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what the deprecation message says:

  /**
     * Sets the goals for the Maven invocation.
     *
     * @param goals The goals for the Maven invocation, may be <code>null</code> to execute the POMs default goal.
     * @return This invocation request.
     * @deprecated simply {@link #addArg(String)} or {@link #addArgs(Collection)} should be used
     */

Is that wrong then? Should this method be undeprecated?

Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correctly deprecated ... but when we use new method we need new parameters where user set each command line argument separately

Parsing, escaping arguments are allwaye error prone, so we should required from users to provided it.

Copy link
Copy Markdown
Member

@michael-o michael-o Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, don't reinvent the wheel you will fail.


try {
InvocationResult invocationResult = invoker.execute(req);
Expand Down
⚡