Skip to content

[SPARK-40398][CORE][SQL] Use Loop instead of Arrays.stream api #37843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 18 commits into from
Closed

[SPARK-40398][CORE][SQL] Use Loop instead of Arrays.stream api #37843

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5c92faa
use loop
LuciferYang Sep 9, 2022
71ff5ff
expression references
LuciferYang Sep 10, 2022
5c5365f
anymatch and all match
LuciferYang Sep 10, 2022
bc19399
sum and avg
LuciferYang Sep 10, 2022
1ecf017
use linked hashset
LuciferYang Sep 11, 2022
9c979c4
to static
LuciferYang Sep 11, 2022
e90991c
imports
LuciferYang Sep 11, 2022
8ff3b77
revert linked hash set
LuciferYang Sep 11, 2022
a16a89b
add comments
LuciferYang Sep 12, 2022
1ee7c4a
add commnets
LuciferYang Sep 12, 2022
46d4a57
change to use HashSet
LuciferYang Sep 13, 2022
a64f608
address comments
LuciferYang Sep 14, 2022
e00330f
address comments
LuciferYang Sep 14, 2022
4892423
fix wrong code
LuciferYang Sep 14, 2022
1a6a3c8
Address srowen's comments
LuciferYang Sep 16, 2022
528f3c5
Merge branch 'upmaster' into ExpressionArrayToStrings
LuciferYang Sep 16, 2022
2343dc8
Merge branch 'upmaster' into ExpressionArrayToStrings
LuciferYang Sep 16, 2022
db94018
Merge branch 'upmaster' into ExpressionArrayToStrings
LuciferYang Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,9 @@ public String build(Expression expr) {
String name = e.name();
switch (name) {
case "IN": {
List<String> children = expressionsToStringList(e.children());
return visitIn(children.get(0), children.subList(1, children.size()));
Expression[] expressions = e.children();
List<String> children = expressionsToStringList(expressions, 1, expressions.length - 1);
return visitIn(build(expressions[0]), children);
}
case "IS_NULL":
return visitIsNull(build(e.children()[0]));
Expand Down Expand Up @@ -393,10 +394,11 @@ private String[] expressionsToStringArray(Expression[] expressions) {
return result;
}

private List<String> expressionsToStringList(Expression[] expressions) {
List<String> list = new ArrayList<>(expressions.length);
for (Expression expression : expressions) {
list.add(build(expression));
private List<String> expressionsToStringList(Expression[] expressions, int offset, int length) {
List<String> list = new ArrayList<>(length);
while (offset < offset + length) {
list.add(build(expressions[offset]));
offset++;
}
return list;
}
Expand Down
⚡