[SQL][MINOR] Update comments and remove dead code in UnionLoop#51097
Closed
Pajaraja wants to merge 1 commit intoapache:masterfrom
Closed
[SQL][MINOR] Update comments and remove dead code in UnionLoop#51097Pajaraja wants to merge 1 commit intoapache:masterfrom
Pajaraja wants to merge 1 commit intoapache:masterfrom
Conversation
cloud-fan
reviewed
Jun 6, 2025
| if (expr.plan.isStreaming) { | ||
| plan.failAnalysis("INVALID_SUBQUERY_EXPRESSION.STREAMING_QUERY", Map.empty) | ||
| } | ||
| assertNoRecursiveCTE(expr.plan) |
Contributor
There was a problem hiding this comment.
is this a behavior change?
Contributor
Author
There was a problem hiding this comment.
It shouldn't be; since now (when we allowed subquery references in recursive CTEs) we replace them with UnionLoopRef, so this will never fail!
As it currently stands, I think this is dead code.
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove function assertNoRecursiveCTE which is no longer used (when recursive references from subqueries were enabled, this function became obsolete).
Also edit comments and error message to reflect current state.
Why are the changes needed?
Code cleanliness.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing golden file tests in cte-recursion and postgreSQL/with.sql.
Was this patch authored or co-authored using generative AI tooling?
No.