Skip to content

[SPARK-52483][INFRA] Upgrade to Python 3.11 in doc image#51150

Closed
zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng:infra_doc_311
Closed

[SPARK-52483][INFRA] Upgrade to Python 3.11 in doc image#51150
zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng:infra_doc_311

Conversation

@zhengruifeng
Copy link
Copy Markdown
Contributor

@zhengruifeng zhengruifeng commented Jun 11, 2025

What changes were proposed in this pull request?

Upgrade to Python 3.11 in doc image

Why are the changes needed?

Python 3.9 is reaching the EOL soon

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI

Was this patch authored or co-authored using generative AI tooling?

No

@zhengruifeng zhengruifeng changed the title [WIP][INFRA] Upgrade to Python 3.11 in doc image [SPARK-52483][INFRA] Upgrade to Python 3.11 in doc image Jun 16, 2025
@zhengruifeng zhengruifeng marked this pull request as ready for review June 16, 2025 06:41
Copy link
Copy Markdown
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

python3.9 -m pip install sphinx_plotly_directive 'numpy>=1.20.0' pyarrow pandas 'plotly<6.0.0'
python3.9 -m pip install 'docutils<0.18.0' # See SPARK-39421
- name: List Python packages
- name: List Python packages for branch-3.5 and branch-4.0
Copy link
Copy Markdown
Contributor

@LuciferYang LuciferYang Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we do not execute the task of documentation generation during the daily tests for the branch-4.0 and branch-3.5

If it is indeed confirmed that the documentation generation task will never be carried out on branches other than the master, perhaps we can simplify the logic here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is needed in a 4.0 PR?

@xinrong-meng
Copy link
Copy Markdown
Member

LGTM thanks!

@zhengruifeng
Copy link
Copy Markdown
Contributor Author

thanks, merged to master

@zhengruifeng zhengruifeng deleted the infra_doc_311 branch June 17, 2025 02:38
dongjoon-hyun added a commit that referenced this pull request Nov 10, 2025
… instead of 3.9

### What changes were proposed in this pull request?

This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9.

### Why are the changes needed?

Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image.
- #48860

https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/docs/README.md?plain=1#L129-L136

When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`.
- #51150
- #51198

### Does this PR introduce _any_ user-facing change?

No behavior change because this is an optional way to generate Spark docs.

### How was this patch tested?

Manually test.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #52959 from dongjoon-hyun/SPARK-54263.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Nov 10, 2025
… instead of 3.9

### What changes were proposed in this pull request?

This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9.

### Why are the changes needed?

Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image.
- #48860

https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/docs/README.md?plain=1#L129-L136

When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`.
- #51150
- #51198

### Does this PR introduce _any_ user-facing change?

No behavior change because this is an optional way to generate Spark docs.

### How was this patch tested?

Manually test.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #52959 from dongjoon-hyun/SPARK-54263.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 6466ed5)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
… instead of 3.9

### What changes were proposed in this pull request?

This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9.

### Why are the changes needed?

Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image.
- apache#48860

https://github.com/apache/spark/blob/996dde53f999de2ec08d7c22929d2b855b99eeab/docs/README.md?plain=1#L129-L136

When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`.
- apache#51150
- apache#51198

### Does this PR introduce _any_ user-facing change?

No behavior change because this is an optional way to generate Spark docs.

### How was this patch tested?

Manually test.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#52959 from dongjoon-hyun/SPARK-54263.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD pushed a commit to huangxiaopingRD/spark that referenced this pull request Nov 25, 2025
… instead of 3.9

### What changes were proposed in this pull request?

This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9.

### Why are the changes needed?

Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image.
- apache#48860

https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/docs/README.md?plain=1#L129-L136

When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`.
- apache#51150
- apache#51198

### Does this PR introduce _any_ user-facing change?

No behavior change because this is an optional way to generate Spark docs.

### How was this patch tested?

Manually test.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#52959 from dongjoon-hyun/SPARK-54263.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants