[SPARK-52483][INFRA] Upgrade to Python 3.11 in doc image#51150
Closed
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-52483][INFRA] Upgrade to Python 3.11 in doc image#51150zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Conversation
57f1e6a to
b727121
Compare
020ef18 to
81e7ec8
Compare
81e7ec8 to
a857b15
Compare
LuciferYang
approved these changes
Jun 16, 2025
| python3.9 -m pip install sphinx_plotly_directive 'numpy>=1.20.0' pyarrow pandas 'plotly<6.0.0' | ||
| python3.9 -m pip install 'docutils<0.18.0' # See SPARK-39421 | ||
| - name: List Python packages | ||
| - name: List Python packages for branch-3.5 and branch-4.0 |
Contributor
There was a problem hiding this comment.
In fact, we do not execute the task of documentation generation during the daily tests for the branch-4.0 and branch-3.5
- https://github.com/apache/spark/actions/runs/15662500049
- https://github.com/apache/spark/actions/runs/15663006363
If it is indeed confirmed that the documentation generation task will never be carried out on branches other than the master, perhaps we can simplify the logic here.
Contributor
Author
There was a problem hiding this comment.
Maybe this is needed in a 4.0 PR?
xinrong-meng
approved these changes
Jun 17, 2025
Member
|
LGTM thanks! |
Contributor
Author
|
thanks, merged to master |
This was referenced Nov 10, 2025
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2025
… instead of 3.9 ### What changes were proposed in this pull request? This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9. ### Why are the changes needed? Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image. - #48860 https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/docs/README.md?plain=1#L129-L136 When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`. - #51150 - #51198 ### Does this PR introduce _any_ user-facing change? No behavior change because this is an optional way to generate Spark docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52959 from dongjoon-hyun/SPARK-54263. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 10, 2025
… instead of 3.9 ### What changes were proposed in this pull request? This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9. ### Why are the changes needed? Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image. - #48860 https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/docs/README.md?plain=1#L129-L136 When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`. - #51150 - #51198 ### Does this PR introduce _any_ user-facing change? No behavior change because this is an optional way to generate Spark docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52959 from dongjoon-hyun/SPARK-54263. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6466ed5) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
… instead of 3.9 ### What changes were proposed in this pull request? This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9. ### Why are the changes needed? Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image. - apache#48860 https://github.com/apache/spark/blob/996dde53f999de2ec08d7c22929d2b855b99eeab/docs/README.md?plain=1#L129-L136 When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`. - apache#51150 - apache#51198 ### Does this PR introduce _any_ user-facing change? No behavior change because this is an optional way to generate Spark docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52959 from dongjoon-hyun/SPARK-54263. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
… instead of 3.9 ### What changes were proposed in this pull request? This PR aims to fix `run-in-container` script to use Python 3.11 instead of 3.9. ### Why are the changes needed? Since Apache Spark 4.0.0, we have an optional way to build docs in Docker image. - apache#48860 https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/docs/README.md?plain=1#L129-L136 When we started to use Python 3.11 instead of 3.9 for Apache Spark 4.1.0, we missed to update this `run-in-container`. - apache#51150 - apache#51198 ### Does this PR introduce _any_ user-facing change? No behavior change because this is an optional way to generate Spark docs. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52959 from dongjoon-hyun/SPARK-54263. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade to Python 3.11 in doc image
Why are the changes needed?
Python 3.9 is reaching the EOL soon
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No