[SPARK-55076][PYTHON] Fix the type hint issue in ml/mllib and add scipy requirement#53841
Closed
gaogaotiantian wants to merge 7 commits intoapache:masterfrom
Closed
[SPARK-55076][PYTHON] Fix the type hint issue in ml/mllib and add scipy requirement#53841gaogaotiantian wants to merge 7 commits intoapache:masterfrom
gaogaotiantian wants to merge 7 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Improvement SPARK-55076 === This comment was automatically generated by GitHub Actions |
zhengruifeng
approved these changes
Jan 17, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
sparrayas that's the preferred type for scipy nowVectorLiketo include other vector like types to simplify our codetype(x)check withisinstance()because that's the recommended way and mypy understands itnumpy1 vs 2 related type hints so they can pass with both versionsWhy are the changes needed?
Currently, local
mypycheck will fail with a lot of failures due to scipy/numpy because our lint image does not include those stubs. This is bad because it's really hard for people to do mypy check locally - they'll think that their environment setup has issues somypyresult is not to be trusted. We want to makemypyresult consistent between CI and local and make it clean.Does this PR introduce any user-facing change?
It should not. Almost all changes are type annotation related.
How was this patch tested?
CI should pass.
Was this patch authored or co-authored using generative AI tooling?
No