[SPARK-55108][PYTHON] Use the latest pandas-stubs for type check#53877
Closed
gaogaotiantian wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-55108][PYTHON] Use the latest pandas-stubs for type check#53877gaogaotiantian wants to merge 3 commits intoapache:masterfrom
gaogaotiantian wants to merge 3 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Improvement SPARK-55108 === This comment was automatically generated by GitHub Actions |
zhengruifeng
approved these changes
Jan 21, 2026
Contributor
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade
pandas-stubsversion (basically do not pin it anymore) and fix all the mypy errors.Why are the changes needed?
pandas-stubssync withpandas- in theory we should use the same version for both. The stubs for numpy is smarter that it actually depends on a specific version.pandas-stubsdoes not do that. However, we should definitely not pin it on a 1.x version.Some of the ignore comments might because we have a low mypy version (we have to do one at a time). I did not really "fix" all typing issues - I explicitly ignored a lot of them. Some of the errors are because our type hint is wrong or inaccurate.
One step at a time. I think we are moving to the right direction.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Let's check CI.
Was this patch authored or co-authored using generative AI tooling?
No