Skip to content

[SPARK-41398][SQL][FOLLOWUP] Update runtime filtering javadoc to reflect relaxed partition constraints#54046

Closed
yyanyy wants to merge 1 commit intoapache:masterfrom
yyanyy:spark-41398-update-javadoc
Closed

[SPARK-41398][SQL][FOLLOWUP] Update runtime filtering javadoc to reflect relaxed partition constraints#54046
yyanyy wants to merge 1 commit intoapache:masterfrom
yyanyy:spark-41398-update-javadoc

Conversation

@yyanyy
Copy link
Copy Markdown
Contributor

@yyanyy yyanyy commented Jan 28, 2026

Update the javadoc for SupportsRuntimeV2Filtering.filter() and SupportsRuntimeFiltering.filter() to reflect the changes made in SPARK-41398, which relaxed the constraint on partition values during runtime filtering.

After that change, scans can now either:

  • Replace partitions with no matching data with empty InputPartitions, or
  • Report only a subset of the original partition values (omitting those with no data)

The previous documentation stated that the "overall number of partitions" must be preserved, which is no longer required. The only constraint is that new partition values not present in the original partitioning cannot be introduced.

What changes were proposed in this pull request?

A javadoc update to follow up on #38924

Why are the changes needed?

To make the java doc up to date for future implementer

Does this PR introduce any user-facing change?

No

How was this patch tested?

compile and checkstyle

Was this patch authored or co-authored using generative AI tooling?

Yes - Claude Opus 4.5

…ect relaxed partition constraints

Update the javadoc for `SupportsRuntimeV2Filtering.filter()` and
`SupportsRuntimeFiltering.filter()` to reflect the changes made in SPARK-41398,
which relaxed the constraint on partition values during runtime filtering.

After that change, scans can now either:
- Replace partitions with no matching data with empty InputPartitions, or
- Report only a subset of the original partition values (omitting those with no data)

The previous documentation stated that the "overall number of partitions" must be
preserved, which is no longer required. The only constraint is that new partition
values not present in the original partitioning cannot be introduced.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added the SQL label Jan 28, 2026
@github-actions
Copy link
Copy Markdown

JIRA Issue Information

=== Sub-task SPARK-41398 ===
Summary: SPJ: Relax constraints on Storage-Partitioned Join when partition keys after runtime filtering do not match
Assignee: Chao Sun
Status: Resolved
Affected: ["3.3.1"]


This comment was automatically generated by GitHub Actions

@yyanyy
Copy link
Copy Markdown
Contributor Author

yyanyy commented Jan 28, 2026

@sunchao @huaxingao @cloud-fan when you have a chance do you mind taking a look at this javadoc update PR, since you were involved in the original doc/changes that this modified? Thank you!

@cloud-fan
Copy link
Copy Markdown
Contributor

thanks, merging to maser! (comment only, no need to run test)

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @yyanyy and @cloud-fan .

SPARK-41398 was released as a part of Apache Spark 3.4.0 three years ago.
We cannot make a follow-up like this.

@dongjoon-hyun
Copy link
Copy Markdown
Member

Maybe, it's a mistake of Claude Opus 4.5?

@yyanyy
Copy link
Copy Markdown
Contributor Author

yyanyy commented Feb 25, 2026

SPARK-41398 was released as a part of Apache Spark 3.4.0 three years ago. We cannot make a follow-up like this.

Thanks for the feedback @dongjoon-hyun ! Sorry I just joined the community and didn't realize follow-ups should be against open JIRA and not the old resolved ones, feedback noted.

@dongjoon-hyun
Copy link
Copy Markdown
Member

Thank you for your participation, @yyanyy . Since we can mitigate before Apache Spark 4.2.0 release, there is no big deal here. It's a world-wide open-source community. :)

We just want to have a trace-ability for all commits at least in terms of Fix Version. So, we recommend to use [FOLLOWUP] tag inside a single release version only. Feel free to open a new JIRA issue, @yyanyy .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants