[SPARK-55999][SS] Enable forceSnapshotUploadOnLag by default #54847
Closed
zifeif2 wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-55999][SS] Enable forceSnapshotUploadOnLag by default #54847zifeif2 wants to merge 2 commits intoapache:masterfrom
zifeif2 wants to merge 2 commits intoapache:masterfrom
Conversation
micheal-o
approved these changes
Mar 19, 2026
anishshri-db
approved these changes
Mar 20, 2026
terana
pushed a commit
to terana/spark
that referenced
this pull request
Mar 23, 2026
### What changes were proposed in this pull request? 1. Config default change (SQLConf.scala): forceSnapshotUploadOnLag default false → true 2. 3 SPARK-51358 tests fixed (StateStoreCoordinatorSuite.scala): Explicitly set forceSnapshotUploadOnLag=false so lag detection tests aren't interfered with by the forced remediation 3. Cleanup (StateStoreCoordinatorSuite.scala): Removed redundant forceSnapshotUploadOnLag -> "true" ### Why are the changes needed? When state store is lagging in uploading snapshot in maintenance thread, turning on this feature allows state store to upload snapshot in query execution thread, which improves query reliability ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The feature is tested in apache#52773 ### Was this patch authored or co-authored using generative AI tooling? yes Closes apache#54847 from zifeif2/enable-force-snapshot. Authored-by: zifeif2 <zifeifeng11@gmail.com> Signed-off-by: Anish Shrigondekar <anish.shrigondekar@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
When state store is lagging in uploading snapshot in maintenance thread, turning on this feature allows state store to upload snapshot in query execution thread, which improves query reliability
Does this PR introduce any user-facing change?
No
How was this patch tested?
The feature is tested in #52773
Was this patch authored or co-authored using generative AI tooling?
yes