[SPARK-56018][PYTHON][FOLLOW-UP] Disable black check by default#54928
Closed
ueshin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56018][PYTHON][FOLLOW-UP] Disable black check by default#54928ueshin wants to merge 1 commit intoapache:masterfrom
ueshin wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
gaogaotiantian
approved these changes
Mar 20, 2026
dongjoon-hyun
approved these changes
Mar 21, 2026
Member
|
Merged to master. |
terana
pushed a commit
to terana/spark
that referenced
this pull request
Mar 23, 2026
### What changes were proposed in this pull request? This is a follow-up of apache#54840. Disables black check by default. ### Why are the changes needed? The python formatter moved from `black` to `ruff` at apache#54840, but `lint-python` still runs the black check if no arguments are provided and there is `black` installed, causing many failures. ```sh % ./dev/lint-python starting python compilation test... python compilation succeeded. starting black test... black checks failed: ... ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#54928 from ueshin/issues/SPARK-56018/disable_black. Authored-by: Takuya Ueshin <ueshin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #54840.
Disables black check by default.
Why are the changes needed?
The python formatter moved from
blacktoruffat #54840, butlint-pythonstill runs the black check if no arguments are provided and there isblackinstalled, causing many failures.Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No.