[SPARK-55969][SQL][3.5][FOLLOW-UP][TESTS] Update SQLQueryTestSuite golden files#55183
Closed
peter-toth wants to merge 1 commit intoapache:branch-3.5from
Closed
[SPARK-55969][SQL][3.5][FOLLOW-UP][TESTS] Update SQLQueryTestSuite golden files#55183peter-toth wants to merge 1 commit intoapache:branch-3.5from
SQLQueryTestSuite golden files#55183peter-toth wants to merge 1 commit intoapache:branch-3.5from
Conversation
Contributor
Author
yaooqinn
approved these changes
Apr 3, 2026
Contributor
|
The change looks good to me, but I do not understand the reason of the change. #54901 should not affect the query plans. |
Contributor
Author
Yeah, it doesn't, most likely just some formatting is different on 3.5... |
Contributor
Author
|
Looks like f844e78 is missing from 3.5. |
Contributor
|
yes, that makes a lot of sense. LGTM, thanks! |
peter-toth
added a commit
that referenced
this pull request
Apr 3, 2026
…golden files ### What changes were proposed in this pull request? Regenerate related golden files after #54901. ### Why are the changes needed? 3.5 PRs (like #55167) currently fail with: ``` [info] - linear-regression.sql_analyzer_test *** FAILED *** (142 milliseconds) [info] linear-regression.sql_analyzer_test [info] Expected "...stRegression`, [k#x,[ y#x, ]x#x]) [info] +- Pr...", but got "...stRegression`, [k#x,[y#x,]x#x]) [info] +- Pr..." Result did not match for query #33 [info] SELECT regr_r2(k, x) FROM testRegression where k=2 (SQLQueryTestSuite.scala:876) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55183 from peter-toth/SPARK-55969-follow-up-3.5. Lead-authored-by: Peter Toth <peter.toth@gmail.com> Co-authored-by: Peter Toth <p_toth@apple.com> Signed-off-by: Peter Toth <peter.toth@gmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Regenerate related golden files after #54901.
Why are the changes needed?
3.5 PRs (like #55167) currently fail with:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.