[SPARK-56383][SQL][TEST] Add tests for partition filter extraction from mixed predicates#55248
Open
szehon-ho wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-56383][SQL][TEST] Add tests for partition filter extraction from mixed predicates#55248szehon-ho wants to merge 2 commits intoapache:masterfrom
szehon-ho wants to merge 2 commits intoapache:masterfrom
Conversation
522bdf2 to
a5dcf6f
Compare
…ed predicates Add tests to DataSourceV2EnhancedPartitionFilterSuite covering the case where getPartitionFiltersAndDataFilters extracts additional partition filters from predicates that reference both partition and data columns (via extractPredicatesWithinOutputSet).
a5dcf6f to
0beb391
Compare
1c6d80d to
3286bf7
Compare
cloud-fan
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add tests to
DataSourceV2EnhancedPartitionFilterSuitecovering the case wheregetPartitionFiltersAndDataFilters(called fromPushDownUtils.pushPartitionPredicates) extracts additional partition filters from predicates that reference both partition and data columns viaextractPredicatesWithinOutputSet.This was one of the goals of SPARK-55596
Why are the changes needed?
Test coverage
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran tests
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude (Cursor)