Skip to content

fix(dependabot): adds required schedule to uv updates#33475

Merged
mistercrunch merged 2 commits intomasterfrom
fix-dependabot-config
May 16, 2025
Merged

fix(dependabot): adds required schedule to uv updates#33475
mistercrunch merged 2 commits intomasterfrom
fix-dependabot-config

Conversation

@rusackas
Copy link
Copy Markdown
Member

SUMMARY

Seems dependabot got more picky somewhere along the line:
image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@korbit-ai
Copy link
Copy Markdown

korbit-ai Bot commented May 16, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label May 16, 2025
@mistercrunch
Copy link
Copy Markdown
Member

Oh good catch. Related -> dependabot/dependabot-core#10040 (comment)

Copy link
Copy Markdown
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do weekly? My intent was to monitor progress and report back on dependabot/dependabot-core#10040 (comment) , so far I don't think dependabot is doing anything or what's required to allow for the magic to happen.

I found out looking at some of the code / PR that dependabot seems to be trying to be magical, finding your reqs files and triggering script based on their headers (I think), so if you requirements.txt has a comment saying # generated using this command, it'll try to run that.

In our case, dependabot should run scripts/uv-pip-compile.sh that runs atomically for all requirements/*.in and I don't think there's anyway to control/configure that in .github/dependabot.yml.

Comment thread .github/dependabot.yml Outdated
@rusackas
Copy link
Copy Markdown
Member Author

Weekly it is! Was just conforming to the rest of 'em. We can switch it back to monthly if it gets too noisy and we want to get hit by the wave less often.

@mistercrunch mistercrunch merged commit 1921ba9 into master May 16, 2025
47 checks passed
@mistercrunch mistercrunch deleted the fix-dependabot-config branch May 16, 2025 19:22
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label May 19, 2025
LevisNgigi pushed a commit to LevisNgigi/superset that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants