Declare 'extend' variable in docker.js#784
Conversation
This 'extend' variable is not being defined which is causing errors in node v20.
|
https://github.com/apocas/dockerode/actions/runs/12610511590/job/35145175728 Not seeing any issues in Node 20.x tests, could you detail? |
|
I'm not sure of why this isn't causing issues in the tests, but new to v4.0.3 our esbuild bundle of our server with dockerode won't start because of this missing "var" declaration. I wonder if it was in a "," chain and then moved to it's own statement, but it's clearly an undefined variable. I am getting errors like: |
|
Yeah it's a typo, I missed the ";" before. Yeah this will not trigger everywhere. |
Updated fix to use ','
|
@apocas Will you accept this PR now (replace ';' with ',')? |
|
v4.0.4 published |
|
Thanks for pushing this out! It has fixed my esbuild usage of this package. |
This 'extend' variable is not being defined which is causing errors in node v20.