add access control support for admin service#3233
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Aug 16, 2020
Merged
add access control support for admin service#3233nobodyiam merged 1 commit intoapolloconfig:masterfrom
nobodyiam merged 1 commit intoapolloconfig:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3233 +/- ##
============================================
+ Coverage 51.05% 51.49% +0.44%
- Complexity 2270 2296 +26
============================================
Files 440 442 +2
Lines 13660 13739 +79
Branches 1389 1398 +9
============================================
+ Hits 6974 7075 +101
+ Misses 6199 6175 -24
- Partials 487 489 +2
Continue to review full report at Codecov.
|
c5cfeea to
a489281
Compare
a489281 to
ae9ba6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Add access control support for admin service so that only trusted apollo portal could access admin service.
Instructions
Configurations for admin service
The following configurations can be set in ApolloConfigDB.ServerConfig.
Specify whether to enable access control for admin service or not. If set to true, then portal must pass the correct token when calling admin service.
Specify the tokens allowed to call admin service, multiple tokens should be separated by
,.If this configuration is empty, then the access control won't take effect.
Configurations for portal
The following configurations can be set in ApolloPortalDB.ServerConfig.
Specify the access tokens for admin service in different environments in json format, e.g.
{ "dev" : "098f6bcd4621d373cade4e832627b4f6", "pro" : "ad0234829205b9033196ba818f7a872b" }Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.