Move apollo-demo, scripts/docker-quick-start and scripts/apollo-on-kubernetes out of main repository#4440
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4440 +/- ##
=========================================
Coverage 53.57% 53.57%
Complexity 2692 2692
=========================================
Files 488 488
Lines 15229 15229
Branches 1587 1587
=========================================
Hits 8159 8159
Misses 6514 6514
Partials 556 556 Continue to review full report at Codecov.
|
9e65604 to
17b208d
Compare
|
After remove apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/xmlConfigDemo/bean/XmlBean.java Do we need to change the javadoc in from |
17b208d to
f90e638
Compare
|
@Anilople That I think is all right as it is only used to explain what SpringValueDefinitionProcessor does - to process the placeholders in Spring XML configuration files. To process xml config placeholders, e.g.
<bean class="com.ctrip.framework.apollo.demo.spring.xmlConfigDemo.bean.XmlBean">
<property name="timeout" value="${timeout:200}"/>
<property name="batch" value="${batch:100}"/>
</bean> |
f90e638 to
57a0136
Compare
What's the purpose of this PR
Move apollo-demo, scripts/docker-quick-start and scripts/apollo-on-kubernetes out of main repository, see #4427.
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.