Migrate away from @testing-library/react-hooks#10415
Conversation
… tests in React 18
|
jerelmiller
left a comment
There was a problem hiding this comment.
Thank you SO SO much for doing this. Super great not to have to remember which renderHook we are using 😄.
Feel free to address/ignore the [nit] comments. There were a couple tests in here that might result in test flake, or false positives with the use of waitFor. I'm happy to approve once we determine if there is an issue there or not.
|
Thanks for the review, @jerelmiller! This is ready for a final pass—mostly minor fixes, with one call-out for the changes in 6d1a204, the least straightforward test refactor in the PR. |
jerelmiller
left a comment
There was a problem hiding this comment.
💯 💯 Nice work! Love when we can reduce dependencies. Thanks so much for doing this for us!
Closes #10333. Many thanks to @eps1lon for the foundation of this PR originating in eps1lon#1 🙏
To Do
hooks/__tests__/useQuery.test.tsxwhich rely on deprecatedresult.allAPIhooks/__tests__/useLazyQuery.test.tsxhooks/__tests__/useQuery.test.tsxChecklist: