Skip to content

Commit 185d6b7

Browse files
Merge pull request #1458 from Backbone-Labs/winston/with-connection-param
Add initial connection parameter to WebSocketTransport
2 parents 2a1d35a + 5af4794 commit 185d6b7

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

Sources/ApolloWebSocket/WebSocketTransport.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public class WebSocketTransport {
2626
public static var provider: ApolloWebSocketClient.Type = ApolloWebSocket.self
2727
public weak var delegate: WebSocketTransportDelegate?
2828

29+
let connectOnInit: Bool
2930
let reconnect: Atomic<Bool>
3031
var websocket: ApolloWebSocketClient
3132
let error: Atomic<Error?> = Atomic(nil)
@@ -103,6 +104,7 @@ public class WebSocketTransport {
103104
/// - Parameter reconnect: Whether to auto reconnect when websocket looses connection. Defaults to true.
104105
/// - Parameter reconnectionInterval: How long to wait before attempting to reconnect. Defaults to half a second.
105106
/// - Parameter allowSendingDuplicates: Allow sending duplicate messages. Important when reconnected. Defaults to true.
107+
/// - Parameter connectOnInit: Whether the websocket connects immediately on creation. If false, remember to call `resumeWebSocketConnection()` to connect. Defaults to true.
106108
/// - Parameter connectingPayload: [optional] The payload to send on connection. Defaults to an empty `GraphQLMap`.
107109
/// - Parameter requestBodyCreator: The `RequestBodyCreator` to use when serializing requests. Defaults to an `ApolloRequestBodyCreator`.
108110
public init(request: URLRequest,
@@ -112,6 +114,7 @@ public class WebSocketTransport {
112114
reconnect: Bool = true,
113115
reconnectionInterval: TimeInterval = 0.5,
114116
allowSendingDuplicates: Bool = true,
117+
connectOnInit: Bool = true,
115118
connectingPayload: GraphQLMap? = [:],
116119
requestBodyCreator: RequestBodyCreator = ApolloRequestBodyCreator()) {
117120
self.connectingPayload = connectingPayload
@@ -123,9 +126,12 @@ public class WebSocketTransport {
123126
self.websocket = WebSocketTransport.provider.init(request: request, protocols: protocols)
124127
self.clientName = clientName
125128
self.clientVersion = clientVersion
129+
self.connectOnInit = connectOnInit
126130
self.addApolloClientHeaders(to: &self.websocket.request)
127131
self.websocket.delegate = self
128-
self.websocket.connect()
132+
if connectOnInit {
133+
self.websocket.connect()
134+
}
129135
self.websocket.callbackQueue = processingQueue
130136
}
131137

0 commit comments

Comments
 (0)