Skip to content

Add initial connection parameter to WebSocketTransport#1458

Merged
designatednerd merged 2 commits intoapollographql:mainfrom
Backbone-Labs:winston/with-connection-param
Oct 20, 2020
Merged

Add initial connection parameter to WebSocketTransport#1458
designatednerd merged 2 commits intoapollographql:mainfrom
Backbone-Labs:winston/with-connection-param

Conversation

@winstondu
Copy link
Copy Markdown
Contributor

@winstondu winstondu commented Oct 18, 2020

Our proposed solution to #1457

@apollo-cla
Copy link
Copy Markdown

apollo-cla commented Oct 18, 2020

@winstondu: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@designatednerd
Copy link
Copy Markdown
Contributor

designatednerd commented Oct 19, 2020

@winstondu Thanks for the PR! Are you assuming that the developer would just need to call updateHeaderValues or updateConnectingPayload, which both call reconnectWebSocket under the hood?

designatednerd
designatednerd reviewed Oct 19, 2020
View reviewed changes
Comment thread Sources/ApolloWebSocket/WebSocketTransport.swift
@designatednerd
Copy link
Copy Markdown
Contributor

designatednerd commented Oct 19, 2020

Test failures seem to be unrelated, I'm not sure what the hell is going on with circle right now

@designatednerd designatednerd linked an issue Oct 19, 2020 that may be closed by this pull request
Create WebsocketTransport without connecting automatically #1457
Closed
@designatednerd
Copy link
Copy Markdown
Contributor

designatednerd commented Oct 19, 2020

Are you able to build this locally? If so, would you mind rebasing back onto main in the hopes that it'll kick Circle hard enough for this to actually work? I don't see anything in here that would reasonably be causing the type of failure I'm seeing in circle without it failing on every other branch

@winstondu
Add websocket initial connection param
1586aef 
Correct typo

Fix another typo
@winstondu winstondu force-pushed the winston/with-connection-param branch from bd74121 to 1586aef Compare October 19, 2020 20:20
@winstondu
Copy link
Copy Markdown
Contributor Author

winstondu commented Oct 19, 2020

@designatednerd , done.

designatednerd
designatednerd reviewed Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK good other than the docs

Comment thread Sources/ApolloWebSocket/WebSocketTransport.swift
@designatednerd
Copy link
Copy Markdown
Contributor

designatednerd commented Oct 19, 2020

LOL CI is such a black box.

@winstondu
Copy link
Copy Markdown
Contributor Author

winstondu commented Oct 19, 2020

OK good other than the docs

Documentation updated.

designatednerd
designatednerd approved these changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI

@designatednerd designatednerd added this to the Next Release milestone Oct 19, 2020
@designatednerd designatednerd merged commit 185d6b7 into apollographql:main Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@designatednerd designatednerd designatednerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.36.0

Development

Successfully merging this pull request may close these issues.

Create WebsocketTransport without connecting automatically

3 participants

@winstondu @apollo-cla @designatednerd
⚡