Skip to content

Commit 26c7bac

Browse files
Merge pull request #1106 from apollographql/fix/spm-name
Add workaround for SPM name
2 parents ad8af44 + 3fbe5f3 commit 26c7bac

4 files changed

Lines changed: 54 additions & 16 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,3 +57,4 @@ scripts/apollo
5757
scripts/apollo.tar.gz
5858
SwiftScripts/ApolloCLI
5959
Tests/ApolloCodegenTests/scripts
60+
Tests/ApolloCodegenTests/scripts directory

Apollo.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,7 @@
368368
9B518C85235F8125004C426D /* CLIDownloader.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CLIDownloader.swift; sourceTree = "<group>"; };
369369
9B518C88235F8AD4004C426D /* CLIDownloaderTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CLIDownloaderTests.swift; sourceTree = "<group>"; };
370370
9B518C8A235F8B05004C426D /* ApolloFilePathHelper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ApolloFilePathHelper.swift; sourceTree = "<group>"; };
371+
9B5A1EE3243284F300F066BB /* Package.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Package.swift; sourceTree = "<group>"; };
371372
9B60204E23FDFA9F00D0C8E0 /* SQLiteCacheTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SQLiteCacheTests.swift; sourceTree = "<group>"; };
372373
9B64F6752354D219002D1BB5 /* URL+QueryDict.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "URL+QueryDict.swift"; sourceTree = "<group>"; };
373374
9B68F03A240D8D1800E97318 /* CodegenExtensionTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CodegenExtensionTests.swift; sourceTree = "<group>"; };
@@ -1088,6 +1089,7 @@
10881089
9FC7503A1D2A532C00458D91 = {
10891090
isa = PBXGroup;
10901091
children = (
1092+
9B5A1EE3243284F300F066BB /* Package.swift */,
10911093
9FC750461D2A532C00458D91 /* Apollo */,
10921094
9B7B6F50233C26E400F32205 /* ApolloCodegenLib */,
10931095
9B7BDACC23FDEBE300ACD198 /* ApolloSQLite */,

Package.swift

Lines changed: 45 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// swift-tools-version:5.1
1+
// swift-tools-version:5.2
22
// The swift-tools-version declares the minimum version of Swift required to build this package.
33

44
import PackageDescription
@@ -36,40 +36,72 @@ let package = Package(
3636
dependencies: []),
3737
.target(
3838
name: "ApolloCodegenLib",
39-
dependencies: ["Stencil"]),
39+
dependencies: [
40+
.product(name: "Stencil", package: "Stencil"),
41+
]),
4042
.target(
4143
name: "ApolloSQLite",
42-
dependencies: ["Apollo", "SQLite"]),
44+
dependencies: [
45+
"Apollo",
46+
.product(name: "SQLite", package: "SQLite.swift"),
47+
]),
4348
.target(
4449
name: "ApolloSQLiteTestSupport",
45-
dependencies: ["ApolloSQLite", "ApolloTestSupport"]),
50+
dependencies: [
51+
"ApolloSQLite",
52+
"ApolloTestSupport"
53+
]),
4654
.target(
4755
name: "ApolloWebSocket",
48-
dependencies: ["Apollo","Starscream"]),
56+
dependencies: [
57+
"Apollo",
58+
.product(name: "Starscream", package: "Starscream"),
59+
]),
4960
.target(
5061
name: "ApolloTestSupport",
51-
dependencies: ["Apollo"]),
62+
dependencies: [
63+
"Apollo",
64+
]),
5265
.target(
5366
name: "GitHubAPI",
54-
dependencies: ["Apollo"]),
67+
dependencies: [
68+
"Apollo",
69+
]),
5570
.target(
5671
name: "StarWarsAPI",
57-
dependencies: ["Apollo"]),
72+
dependencies: [
73+
"Apollo",
74+
]),
5875

5976
.testTarget(
6077
name: "ApolloTests",
61-
dependencies: ["ApolloTestSupport", "StarWarsAPI"]),
78+
dependencies: [
79+
"ApolloTestSupport",
80+
"StarWarsAPI",
81+
]),
6282
.testTarget(
6383
name: "ApolloCacheDependentTests",
64-
dependencies: ["ApolloSQLiteTestSupport", "StarWarsAPI"]),
84+
dependencies: [
85+
"ApolloSQLiteTestSupport",
86+
"StarWarsAPI",
87+
]),
6588
.testTarget(
6689
name: "ApolloCodegenTests",
67-
dependencies: ["ApolloCodegenLib"]),
90+
dependencies: [
91+
"ApolloCodegenLib"
92+
]),
6893
.testTarget(
6994
name: "ApolloSQLiteTests",
70-
dependencies: ["ApolloSQLiteTestSupport", "StarWarsAPI"]),
95+
dependencies: [
96+
"ApolloSQLiteTestSupport",
97+
"StarWarsAPI"
98+
]),
7199
.testTarget(
72100
name: "ApolloWebsocketTests",
73-
dependencies: ["ApolloWebSocket", "ApolloTestSupport", "StarWarsAPI"]),
101+
dependencies: [
102+
"ApolloWebSocket",
103+
"ApolloTestSupport",
104+
"StarWarsAPI",
105+
]),
74106
]
75107
)

docs/source/swift-scripting.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,13 @@ To begin, let's set up a Swift Package Manager executable:
2828
4. Update the `dependencies` section to grab the Apollo iOS library:
2929
3030
```swift
31-
.package(url: "https://github.com/apollographql/apollo-ios.git",
32-
from: "0.22.0")
31+
.package(name: "Apollo",
32+
url: "https://github.com/apollographql/apollo-ios.git",
33+
.upToNextMinor(from: "0.24.0"))
3334
```
34-
**NOTE**: The version should be identical to the version you're using in your main project.
35+
**NOTE**: The version should be identical to the version you're using in your main project. \
36+
37+
**ALSO NOTE**: Having to specify the name is a workaround for [SR-12110](https://bugs.swift.org/browse/SR-12210). Hopefully once that's fixed, SPM should pick up the name automatically.
3538
3639
5. For the main executable target in the `targets` section, add `ApolloCodegenLib` as a dependency:
3740

0 commit comments

Comments
 (0)