Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues pointed out in #1102 and #1105.
The issue is that for some reason Swift 5.2 is not picking up on
Package.swift's name property correctly for use with aproductin a dependency. I have not been able to figure out why - I tried renaming the package toApollooootemporarily and whilePackage.resolvedpicked that up, it still caused the same error.I've added details on to SR-12210, which appears to be the same issue.
The workaround for the moment is to manually specify the name of the dependency, which is easy if obnoxious. I've updated our documentation to reflect this recommendation.
Also in this PR:
Package.swiftfor main lib to useswift-tools-version5.2 and use style accordinglyPackage.swiftto the main.xcodeprojbecause I'm sick of having to hunt for it manually 😆gitignoreto also ignore new folder for testing codegen lib downloads