Fix package dependency syntax#1105
Fix package dependency syntax#1105alexandrethsilva wants to merge 1 commit intoapollographql:masterfrom
Conversation
|
@alexandrethsilva: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
I think this issue points to me needing to update something in Good call on the |
|
@designatednerd should I drop this PR for the time being or would you like me to maybe take a different approach? |
|
Let's leave this up for now, I'm working on a fix but until it's actually ready this will at least help anyone who's stuck |
|
@alexandrethsilva I'd like to close this out in favor of #1106 - I really appreciate you taking the time to make this but I want to have the extra context I've added in that PR. is that cool? |
|
Went ahead and merged #1106 so I'm gonna close this out - thanks again for helping figure this out! |
|
Hi @designatednerd, sure! Glad that I could help out a bit. 🤓 |
@designatednerd I went ahead and made the PR related to #1102 in case you'd like to have it merged as I will probably be offline for a few hours.
One thing I'd like to ask though, is whether it would make sense to have the officially suggested syntax pointing to an exact version rather then a range and updating the docs as new versions are released, as in:
I ask for a few reasons:
Let me know if any of this makes sense and whether I should update the PR to make it align with these points.
Cheers!