Example codegen script fails with folders having whitespace in their names

👋

The API.swift generating script from https://www.apollographql.com/docs/ios/installation.html#adding-build-step fails on folders having whitespace in their name like User Search:

exec apollo-codegen generate ./Controllers/Users Search/UserSearch.graphql --schema 'Supporting Files/schema.json' --output API.swift
Error: ENOENT: no such file or directory, open '<full path to my app>/Controllers/Users'
  ... etc

I think this happens because of $(find . -name '*.graphql'). It doesn't put quotes around the files it finds.

Should there be a note about it for those not familiar with unix tools?

Some thing like

sh-3.2$ echo $(find . -name '*.graphql' | sed -e 's/$/"/g' -e 's/^/"/g' | tr '\n' ' ')
"./Controllers/Users Search/UserSearch.graphql"

could have worked. But js seems to be trying to prepend the full path and returns

Error: ENOENT: no such file or directory, open '/Users/kluuf/Developer/testapp/"./Controllers/Users'
    at Object.fs.openSync (fs.js:660:18)
    at Object.fs.readFileSync (fs.js:565:33)
    at inputPaths.map.inputPath (/usr/local/lib/node_modules/apollo-codegen/src/loading.ts:69:21)
    at Array.map (<anonymous>)
    at Object.loadAndMergeQueryDocuments (/usr/local/lib/node_modules/apollo-codegen/src/loading.ts:68:30)
    at Object.generate (/usr/local/lib/node_modules/apollo-codegen/src/generate.ts:31:20)
    at Object.yargs.command.command.command.argv [as handler] (/usr/local/lib/node_modules/apollo-codegen/src/cli.js:191:7)
    at Object.self.runCommand (/usr/local/lib/node_modules/apollo-codegen/node_modules/yargs/lib/command.js:233:22)
    at Object.Yargs.self._parseArgs (/usr/local/lib/node_modules/apollo-codegen/node_modules/yargs/yargs.js:990:30)
    at Object.get [as argv] (/usr/local/lib/node_modules/apollo-codegen/node_modules/yargs/yargs.js:927:19)

$ find `pwd` -name '*.graphql' | sed -e 's/$/"/g' -e 's/^/"/g' | tr '\n' ' '
"/Users/kluuf/Developer/testapp/Controllers/Users Search/UserSearch.graphql"

doesn't work either

sh-3.2$ apollo-codegen generate $(find `pwd` -name '*.graphql' | sed -e 's/$/"/g' -e 's/^/"/g' | tr '\n' ' ') --schema 'Supporting Files/schema.json' --output API.swift
Error: ENOENT: no such file or directory, open '/Users/kluuf/Developer/testapp/"/Users/kluuf/Developer/testapp/Controllers/Users'

I hoped it would recognize an absolute path and not try to prepend anything ...

It ignores escaped whitespace as well

sh-3.2$ apollo-codegen generate $(find . -name '*.graphql' | sed 's/ /\\ /g') --schema 'Supporting Files/schema.json' --output API.swift
Error: ENOENT: no such file or directory, open '/Users/kluuf/Developer/testapp/Controllers/Users\'

apollo-codegen generate seems to be just splitting by . Don't know what to do then.

If it put quotes around its arguments or accepted absolute paths to the files, that wouldn't have been an issue.

[martijnwalraven]

I think you can avoid this by relying on apollo-codegen to do the expansion, something like apollo-codegen generate "**/*.graphql" should work.

[designatednerd]

This should be addressed with the changes to the build script in 0.11.0 (caveat: Watch out for the stray whitespace I fixed in #618). I'm going to close this, please open a new issue if you're still having problems. Thank you!