Add apollo custom extension to replace apollo_ prefix#1183
Add apollo custom extension to replace apollo_ prefix#1183designatednerd merged 4 commits intoapollographql:masterfrom
apollo_ prefix#1183Conversation
|
@yuzushioh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
yuzushioh
changed the title
apollo_ prefixapollo_ prefix
|
@designatednerd |
|
@yuzushioh Prooooobably not, that test is super flaky, I'll kick it |
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
One minor thing but otherwise this is looking nice!
Note that since this is technically going to be a break I'll need to put it in a minor version, so I may hold off on merging it for a few days until I have something else breaking.
| extension Optional where Wrapped == Bool { | ||
|
|
||
| var apollo_boolValue: Bool { | ||
| var valueOrFalseIfNone: Bool { |
There was a problem hiding this comment.
I'd still like to keep this as boolValue - ultimately it behaves similarly to [NSNumber boolValue] in that if you call it on nil it returns false.
There was a problem hiding this comment.
OK. I changed it to boolValue with a comment on it.
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Looks good! I'm going to hold off on merging this for a few days to make sure I don't need to do more patches for 0.27.x, but I'll put it out with our next minor!
3 participants
Added
ApolloExtensionand replaceapollo_prefix byapollo.ref: #1170