Added option to generate a custom scalar with a prefix.#1216
Merged
designatednerd merged 2 commits intoapollographql:masterfrom May 19, 2020
Merged
Added option to generate a custom scalar with a prefix.#1216designatednerd merged 2 commits intoapollographql:masterfrom
designatednerd merged 2 commits intoapollographql:masterfrom
Conversation
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Oooh - yeah I like this better. It's a breaking change but I think in a good way. Gonna close mine out!
| /// Enum to select how to handle properties using a custom scalar from the schema. | ||
| public enum CustomScalarFormat: Equatable { | ||
| /// Uses a default type instead of a custom scalar. | ||
| case `default` |
Contributor
There was a problem hiding this comment.
I would call this none rather than default, since it's applying no formatting to custom scalars.
Contributor
|
The test failure is a known flaky test, FYI |
- Renamed CustomScalarFormat.default to none since it isnt applying any formatting. - Added the passthroughCustomScalars flag when using passthroughWithPrefix to be safe. The CLI documentation doesnt mention that that flag is added when using customScalarsPrefix.
designatednerd
approved these changes
May 19, 2020
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
LGTM pending the kicked build - will probably merge this tomorrow. Thanks for pointing this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1214
Added an option to
ApolloCodegenOptionsto take aCustomScalarFormatenum which can be eitherdefault,passthroughorpassthroughWithPrefix(String)