Update WebSockTransport request header and connectingPayload#1224
Merged
designatednerd merged 3 commits intoapollographql:masterfrom May 26, 2020
Merged
Conversation
|
@yootsubo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
|
Awesome - any chance you've got a minute to throw some tests on for this? |
|
Thanks for doing this, got swamped the last few days! |
Author
|
@designatednerd Tests added! Let me know if theres anything else :) |
designatednerd
approved these changes
May 26, 2020
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Sweet! I might do some stuff tomorrow to have it hit a live websocket on localhost instead of using a mock socket, but this is fantastic. Thanks so much for your help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1178
In addition, added a similar functionality to update the
connectingPayload.This is to handle similar use case to #1178 but for those who use the
connectingPayloadto send the auth token (what my team is currently doing).