Update CLI to include switching lets to vars to prevent memory overuse#1246
Merged
designatednerd merged 4 commits intomasterfrom Jun 7, 2020
Merged
Update CLI to include switching lets to vars to prevent memory overuse#1246designatednerd merged 4 commits intomasterfrom
designatednerd merged 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #230, where
static letallocation of[GraphQLSelection]arrays meant that they were all allocated at load time rather than at the point of use. This PR transitions the generated code to using computedstatic varsso that the memory is only taken up when it's actually being used.Big props to @gsabran for picking up on what the underlying issue is here.