Merged
Conversation
This was referenced Jun 29, 2020
492191d to
4dbde0c
Compare
Contributor
Author
|
Gonna go ahead and merge this one and put it out with the next version of the lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @vandyshev for pointing this out in #1081. The solution there unfortunately wound up hammering arrays of files, but it gave me a place to start for this bit which works with both multiple files with the same field name and multiple files with different field names.
Previously, we were appending an index to every field name when uploading multiple files. This worked if the files all had the same name, but did not if they had different names. This PR makes updates to ensure that if you are uploading multiple files with different variable names, the correct variable name is included.
The
testMultipleFilesWithMultipleFieldsWithApolloRequestCreatortest case will show the expected output.