Add the ability to set custom http headers for HTTPNetworkTransport#131
Closed
gabrielar wants to merge 1 commit intoapollographql:masterfrom
gabrielar:feature/custom-headers-for-http-transport
Closed
Add the ability to set custom http headers for HTTPNetworkTransport#131gabrielar wants to merge 1 commit intoapollographql:masterfrom gabrielar:feature/custom-headers-for-http-transport
gabrielar wants to merge 1 commit intoapollographql:masterfrom
gabrielar:feature/custom-headers-for-http-transport
Conversation
…ing initialisation; this block provides custom headers to the http request.
|
@gabrielar: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
3 tasks
Contributor
|
Hey @gabrielar - Thank you for doing this, and sorry for the long radio silence on our end! Unfortunately since so much has changed since this PR was opened, I'm going to close this in favor of the work happening in #602 to implement this feature. Please feel free to chime in there if you have thoughts or questions, and open issues on anything you feel we may be leaving out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is necessary to provide custom http headers, eg. to pass requests through a gateway. Thus this pull request adds functionality that does just that by adding an extra parameter to the HTTPNetworkTransport init method. This parameter is a block which is run for each request and must return a dictionary of type [String: String] which will be used to set up the HTTPRequest headers.